Re: [PATCH 3/3] mtd: parsers: ofpart: support BCM4908 fixed partitions

From: Miquel Raynal
Date: Tue Jan 19 2021 - 10:59:17 EST


Hi Rafał,

Rafał Miłecki <zajec5@xxxxxxxxx> wrote on Fri, 15 Jan 2021 16:39:01
+0100:

> From: Rafał Miłecki <rafal@xxxxxxxxxx>
>
> BCM4908 partitioning is based on fixed layout but allows specifying
> multiple firmware partitions. It requires detecting which firmware
> partition was used for booting current kernel.
>
> To support such cases without duplicating a lot of code (without copying
> most of the ofpart.c code) support for post-parsing callback was added.
>
> BCM4908 callback simply reads offset of currently used firmware
> partition from the DT. Bootloader specifies it using the "brcm_blparms"
> property.
>
> Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>

The approach looks fine by me, let's see what other maintainers think.


Cheers,
Miquèl