Re: [PATCH v6 1/6] scsi: ufs: Add "wb_on" sysfs node to control WB on/off

From: Bean Huo
Date: Tue Jan 19 2021 - 11:36:53 EST


On Tue, 2021-01-19 at 12:00 +0200, Adrian Hunter wrote:
> > > Is it so, that after a full reset, WB is always enabled again?
> > > Is
> > > that
> > > intended?
> >
> > Hello Adrian
> > Good questions. yes, after a full reset, the UFS device side by
> > default
> > is wb disabled, then WB will be always enabled agaion in
> > ufshcd_wb_config(hba). but, for the platform which
> > supports UFSHCD_CAP_CLK_SCALING, wb will be disabled again while
> > clk
> > scaling down and enabled while clk scaling up.
> >
> > Regarding the last question, I think OEM wants to do that. maybe
> > they
> > suppose there will be a lot of writing after reset?? From the UFS
> > device's point of view, the control of WB is up to the user.
>
> If it is by design enabled after reset, then perhaps it should be
> mentioned
> in the sysfs documentation.

ok, will add it in the next version.

thanks,
Bean