Re: [PATCH v1 1/1] arm64: dts: stingray: fix usb dma address translation

[Ray Jui]

On 1/18/2021 9:34 PM, Rayagonda Kokatanur wrote:
> From: Bharat Gooty <bharat.gooty@xxxxxxxxxxxx>
> 
> Add a non-empty dma-ranges so that dma address translation
> happens.
> 
> Fixes: 2013a4b684b6 ("arm64: dts: broadcom: clear the warnings caused by empty dma-ranges")
> 
> Signed-off-by: Bharat Gooty <bharat.gooty@xxxxxxxxxxxx>
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@xxxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi b/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi
> index aef8f2b00778..5401a646c840 100644
> --- a/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi
> +++ b/arch/arm64/boot/dts/broadcom/stingray/stingray-usb.dtsi
> @@ -4,11 +4,16 @@
>   */
>  	usb {
>  		compatible = "simple-bus";
> -		dma-ranges;
>  		#address-cells = <2>;
>  		#size-cells = <2>;
>  		ranges = <0x0 0x0 0x0 0x68500000 0x0 0x00400000>;
>  
> +		/*
> +		 * Internally, USB bus to the interconnect can only address up
> +		 * to 40-bit
> +		 */
> +		dma-ranges = <0 0 0 0 0x100 0x0>;
> +

Should have had my signed-off since during our internal review, I added
the above comment to explain why we set it to 40-bit here despite the
USB controller itself is capable of addressing 64-bit as Arnd pointed out.

Well, the following ack should do it too, thanks.

Acked-by: Ray Jui <ray.jui@xxxxxxxxxxxx>

>  		usbphy0: usb-phy@0 {
>  			compatible = "brcm,sr-usb-combo-phy";
>  			reg = <0x0 0x00000000 0x0 0x100>;
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature