Re: [PATCH] net: systemport: free dev before on error path

From: Florian Fainelli
Date: Wed Jan 20 2021 - 00:13:22 EST




On 1/19/2021 8:44 PM, Pan Bian wrote:
> On the error path, it should goto the error handling label to free
> allocated memory rather than directly return.
>
> Fixes: 6328a126896e ("net: systemport: Manage Wake-on-LAN clock")
> Signed-off-by: Pan Bian <bianpan2016@xxxxxxx>

The change is correct, but not the Fixes tag, it should be:

Fixes: 31bc72d97656 ("net: systemport: fetch and use clock resources")

Acked-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
--
Florian