Re: [PATCH] of: property: Add device link support for interrupts

[Geert Uytterhoeven]

Hi Saravana,

On Wed, Jan 20, 2021 at 10:53 AM Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
> On Fri, Dec 18, 2020 at 10:11 PM Saravana Kannan <saravanak@xxxxxxxxxx> wrote:
> > Add support for creating device links out of interrupts property.
> >
> > Cc: Marc Zyngier <maz@xxxxxxxxxx>
> > Cc: Kevin Hilman <khilman@xxxxxxxxxxxx>
> > Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx>
>
> Thanks for your patch!
>
> This does not seem to add all links.  I see links being created to the
> secondary interrupt controller (e61c0000 "renesas,irqc"), but not to
> the primary interrupt controller (GIC)
>
> Which is good, as the GIC driver is not a platform_driver, and thus
> creating links would break everything ;-)

of_link_to_phandle() ignores device nodes where OF_POPULATED
is set, and of_irq_init() sets that flag.  Hence the GIC is ignored.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds