Re: [PATCH v4 2/5] kasan: Add KASAN mode kernel parameter

From: Vincenzo Frascino
Date: Wed Jan 20 2021 - 09:47:16 EST


Hi Andrey,

On 1/19/21 6:10 PM, Andrey Konovalov wrote:
> On Mon, Jan 18, 2021 at 7:30 PM Vincenzo Frascino
> <vincenzo.frascino@xxxxxxx> wrote:
>> --- a/Documentation/dev-tools/kasan.rst
>> +++ b/Documentation/dev-tools/kasan.rst
>> @@ -162,6 +162,9 @@ particular KASAN features.
>>
>> - ``kasan=off`` or ``=on`` controls whether KASAN is enabled (default: ``on``).
>>
>> +- ``kasan.mode=sync`` or ``=async`` controls whether KASAN is configured in
>> + synchronous or asynchronous mode of execution (default: ``sync``).
> This needs to be expanded with a short explanation of the difference.
>

Ok, I will extend it in v5.

>> +static inline void hw_enable_tagging_mode(void)
>> +{
>> + if (kasan_arg_mode == KASAN_ARG_MODE_ASYNC)
>> + hw_enable_tagging_async();
>> + else
>> + hw_enable_tagging_sync();
>> +}
> It's OK to open-code this in kasan_init_hw_tags_cpu(), no need for an
> additional function.
>

I added the new function to keep the code cleaner, but I do not have strong
opinion hence it is fine by me to have open-code here.

--
Regards,
Vincenzo