Re: [PATCH] mm/filemap: Remove redundant variable's assignment

From: Miaohe Lin
Date: Mon Jan 25 2021 - 01:32:14 EST


On 2021/1/25 11:20, Baolin Wang wrote:
> We've already set the variable 'i' 's initial value before using it,
> thus remove redundant previous assignment of variable 'i'.
>
> Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>
> ---
> mm/filemap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/filemap.c b/mm/filemap.c
> index e4906f5..07b02f3 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -2472,7 +2472,6 @@ ssize_t generic_file_buffered_read(struct kiocb *iocb,
> if ((iocb->ki_flags & IOCB_WAITQ) && written)
> iocb->ki_flags |= IOCB_NOWAIT;
>
> - i = 0;
> pg_nr = generic_file_buffered_read_get_pages(iocb, iter,
> pages, nr_pages);
> if (pg_nr < 0) {
>

Reviewed-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>