Re: [External] Re: [PATCH v13 02/12] mm: hugetlb: introduce a new config HUGETLB_PAGE_FREE_VMEMMAP

From: David Rientjes
Date: Tue Jan 26 2021 - 04:22:50 EST


On Mon, 25 Jan 2021, Muchun Song wrote:

> > >> I'm not sure I understand the rationale for providing this help text if
> > >> this is def_bool depending on CONFIG_HUGETLB_PAGE. Are you intending that
> > >> this is actually configurable and we want to provide guidance to the admin
> > >> on when to disable it (which it currently doesn't)? If not, why have the
> > >> help text?
> > >
> > > This is __not__ configurable. Seems like a comment to help others
> > > understand this option. Like Randy said.
> >
> > Yes, it could be written with '#' (or "comment") comment syntax instead of as help text.
>
> Got it. I will update in the next version. Thanks.
>

I'm not sure that Kconfig is the right place to document functional
behavior of the kernel, especially for non-configurable options. Seems
like this is already served by existing comments added by this patch
series in the files where the description is helpful.