Re: [PATCH net-next 3/6] net: ipa: drop packet if status has valid tag

[Alex Elder]

On 1/25/21 9:27 PM, Jakub Kicinski wrote:
> On Mon, 25 Jan 2021 15:29:44 -0600 Alex Elder wrote:
> > Introduce ipa_endpoint_status_tag(), which returns true if received
> > status indicates its tag field is valid.  The endpoint parameter is
> > not yet used.
> >
> > Call this from ipa_status_drop_packet(), and drop the packet if the
> > status indicates the tag was valid.  Pass the endpoint pointer to
> > ipa_status_drop_packet(), and rename it ipa_endpoint_status_drop().
> > The endpoint will be used in the next patch.
> >
> > Signed-off-by: Alex Elder <elder@xxxxxxxxxx>
>
> > @@ -1172,11 +1175,22 @@ static bool ipa_endpoint_status_skip(struct ipa_endpoint *endpoint,
> >   	return false;	/* Don't skip this packet, process it */
> >   }
> >   
> > +static bool ipa_endpoint_status_tag(struct ipa_endpoint *endpoint,
> > +				    const struct ipa_status *status)
> > +{
> > +	return !!(status->mask & IPA_STATUS_MASK_TAG_VALID_FMASK);
>
> drivers/net/ipa/ipa_endpoint.c:1181:25: warning: restricted __le16 degrades to integer

Wow, that's an important one.

Sparse is spewing errors for me.  I guess I'm finally going to have
to figure out what's wrong.

I'll send an update tomorrow.  I know how to fix it but I want to
verify it works before I send it out.

Thank you.

					-Alex

> > +}
> > +