Re: [PATCH] usb: dwc3: add EXPORT_SYMBOL_GPL for role init functions

From: Ray Chi
Date: Tue Jan 26 2021 - 07:18:45 EST


On Tue, Jan 26, 2021 at 6:01 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Tue, Jan 26, 2021 at 05:49:13PM +0800, Ray Chi wrote:
> > Currently, role init functions are used in dwc3 driver but
> > can't be called from kernel modules.
> > dwc3_host_init
> > dwc3_host_exit
> > dwc3_gadget_init
> > dwc3_gadget_exit
> > dwc3_event_buffers_setup
> > dwc3_event_buffers_cleanup
> >
> > If other kernel modules want to use these functions, it needs
> > EXPORT_SYMBOL_GPL() to get compile pass.
> >
> > Signed-off-by: Ray Chi <raychi@xxxxxxxxxx>
>
> What current kernel configuration fails without this patch applied? I
> don't see any in-tree users of this as a module that would break, or am
> I missing something?
>
> thanks,
>
> greg k-h

There is no failure for current status. This patch is just used for
any kernel modules
which want to call these functions. I think it is an expandability of
dwc3 core driver.