Re: [PATCH v3 2/3] x509: Add support for parsing x509 certs with NIST p256 keys

From: Herbert Xu
Date: Wed Jan 27 2021 - 14:35:36 EST


On Wed, Jan 27, 2021 at 07:33:49AM -0500, Stefan Berger wrote:
>
> +static struct akcipher_alg ecc_nist_p256 = {
> + .verify = ecdsa_verify,
> + .set_pub_key = ecc_set_pub_key,
> + .max_size = ecc_nist_p256_max_size,
> + .init = ecc_nist_p256_init_tfm,
> + .exit = ecc_exit_tfm,
> + .base = {
> + .cra_name = "nist_p256",
> + .cra_driver_name = "ecc-nist-p256",
> + .cra_priority = 100,
> + .cra_module = THIS_MODULE,
> + .cra_ctxsize = sizeof(struct ecc_ctx),
> + },
> +};

This is not how we name generic algorithms.

Please split this out and submit them through the crypto tree
instead.

Thanks,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt