Re: [PATCH] kasan: export kasan_poison

From: Andrey Konovalov
Date: Wed Jan 27 2021 - 16:29:09 EST


On Mon, Jan 25, 2021 at 12:28 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
>
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The unit test module fails to build after adding a reference
> to kasan_poison:
>
> ERROR: modpost: "kasan_poison" [lib/test_kasan.ko] undefined!
>
> Export this symbol to make it available to loadable modules.

Could you share the config you used to trigger this?

> Fixes: b9b322c2bba9 ("kasan: add match-all tag tests")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> mm/kasan/shadow.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/kasan/shadow.c b/mm/kasan/shadow.c
> index de6b3f074742..32e7a5c148e6 100644
> --- a/mm/kasan/shadow.c
> +++ b/mm/kasan/shadow.c
> @@ -94,6 +94,7 @@ void kasan_poison(const void *address, size_t size, u8 value)
>
> __memset(shadow_start, value, shadow_end - shadow_start);
> }
> +EXPORT_SYMBOL_GPL(kasan_poison);

Should this be _GPL? All of the other EXPORT_SYMBOL() we use in KASAN
are without the GPL suffix.

>
> void kasan_unpoison(const void *address, size_t size)
> {
> --
> 2.29.2
>