Re: [PATCH 07/22] perf daemon: Add daemon command

[Jiri Olsa]

On Wed, Jan 27, 2021 at 04:09:18PM +0900, Namhyung Kim wrote:
> Hi Jiri,
> 
> On Sun, Jan 3, 2021 at 7:05 AM Jiri Olsa <jolsa@xxxxxxxxxx> wrote:
> > +int cmd_daemon(int argc, const char **argv)
> > +{
> > +       struct option daemon_options[] = {
> > +               OPT_INCR('v', "verbose", &verbose, "be more verbose"),
> > +               OPT_STRING(0, "config", &__daemon.config,
> > +                       "config file", "config file path"),
> > +               OPT_STRING_OPTARG('x', "field-separator", &__daemon.csv_sep,
> > +                       "field separator", "print counts with custom separator", ":"),
> 
> Oh, I didn't expect it's optional and default to ":" instead of ",".

np, I can change the default to ','

jirka

> 
> Thanks,
> Namhyung
> 
> 
> > +               OPT_END()
> > +       };
>