Re: [PATCH 1/2] ARM: dts: am335x-pocketbeagle: unique gpio-line-names

From: Linus Walleij
Date: Thu Jan 28 2021 - 07:03:24 EST


On Wed, Jan 27, 2021 at 1:04 AM Drew Fustini <drew@xxxxxxxxxxxxxxx> wrote:

> Based on linux-gpio discussion [1], it is best practice to make the
> gpio-line-names unique. Generic names like "[ethernet]" are replaced
> with the name of the unique signal on the AM3358 SoC ball corresponding
> to the gpio line. "[NC]" is also renamed to the standard "NC" name to
> represent "not connected".
>
> [1] https://lore.kernel.org/linux-gpio/20201216195357.GA2583366@x1/
>
> Signed-off-by: Drew Fustini <drew@xxxxxxxxxxxxxxx>

This certainly looks better!
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij