Re: [PATCH 1/1] iommu/vt-d: Correctly check addr alignment in qi_flush_dev_iotlb_pasid()

From: Joerg Roedel
Date: Thu Jan 28 2021 - 07:18:39 EST


On Tue, Jan 19, 2021 at 12:35:00PM +0800, Lu Baolu wrote:
> An incorrect address mask is being used in the qi_flush_dev_iotlb_pasid()
> to check the address alignment. This leads to a lot of spurious kernel
> warnings:
>
> [ 485.837093] DMAR: Invalidate non-aligned address 7f76f47f9000, order 0
> [ 485.837098] DMAR: Invalidate non-aligned address 7f76f47f9000, order 0
> [ 492.494145] qi_flush_dev_iotlb_pasid: 5734 callbacks suppressed
> [ 492.494147] DMAR: Invalidate non-aligned address 7f7728800000, order 11
> [ 492.508965] DMAR: Invalidate non-aligned address 7f7728800000, order 11
>
> Fix it by checking the alignment in right way.
>
> Fixes: 288d08e780088 ("iommu/vt-d: Handle non-page aligned address")
> Reported-and-tested-by: Guo Kaijie <Kaijie.Guo@xxxxxxxxx>
> Signed-off-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> Cc: Liu Yi L <yi.l.liu@xxxxxxxxx>
> ---
> drivers/iommu/intel/dmar.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied for 5.11, thanks.