Re: [PATCH 00/12] Rid W=1 warnings from Thunderbolt

From: Lee Jones
Date: Thu Jan 28 2021 - 08:17:29 EST


On Thu, 28 Jan 2021, Mika Westerberg wrote:

> Hi Lee,
>
> On Wed, Jan 27, 2021 at 11:25:42AM +0000, Lee Jones wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > Only 1 small set required for Thunderbolt. Pretty good!
> >
> > Lee Jones (12):
> > thunderbolt: dma_port: Remove unused variable 'ret'
> > thunderbolt: cap: Fix kernel-doc formatting issue
> > thunderbolt: ctl: Demote non-conformant kernel-doc headers
> > thunderbolt: eeprom: Demote non-conformant kernel-doc headers to
> > standard comment blocks
> > thunderbolt: pa: Demote non-conformant kernel-doc headers
> > thunderbolt: xdomain: Fix 'tb_unregister_service_driver()'s 'drv'
> > param
> > thunderbolt: nhi: Demote some non-conformant kernel-doc headers
> > thunderbolt: tb: Kernel-doc function headers should document their
> > parameters
> > thunderbolt: swit: Demote a bunch of non-conformant kernel-doc headers
> > thunderbolt: icm: Fix a couple of formatting issues
> > thunderbolt: tunnel: Fix misspelling of 'receive_path'
> > thunderbolt: swit: Fix function name in the header
>
> I applied all of the changes that touch static functions. For non-static
> functions I will send a patch set shortly that adds the missing bits for
> the kernel-doc descriptions. I also fixed $subject lines of few patches
> ("switch:" instead of "swit:").

Oh, that's odd. This must be a bug in my script.

As I strip [ch], as in *.c and *.h.

Thanks for noticing.

> Please check that I got everything correct in
>
> git://git.kernel.org/pub/scm/linux/kernel/git/westeri/thunderbolt.git next
>
> Thanks!

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog