Re: [PATCH] pwm: fix semicolon.cocci warnings

From: Uwe Kleine-König
Date: Thu Jan 28 2021 - 15:58:28 EST


Hello,

On Thu, Jan 28, 2021 at 09:45:37PM +0800, kernel test robot wrote:
> From: kernel test robot <lkp@xxxxxxxxx>
>
> drivers/pwm/pwm-lpc18xx-sct.c:292:2-3: Unneeded semicolon
>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: e96c0ff4b1e0 ("pwm: Enable compile testing for some of drivers")

This looks wrong. e96c0ff4b1e0 only touches drivers/pwm/Kconfig.

The ; was introduced by commit 841e6f90bb78 ("pwm: NXP LPC18xx PWM/SCT
driver")

Best regards
Uwe

> CC: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: kernel test robot <lkp@xxxxxxxxx>
> ---
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 76c057c84d286140c6c416c3b4ba832cd1d8984e
> commit: e96c0ff4b1e013a4e9174344b0fcda0d566d3689 pwm: Enable compile testing for some of drivers
>
> pwm-lpc18xx-sct.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/pwm/pwm-lpc18xx-sct.c
> +++ b/drivers/pwm/pwm-lpc18xx-sct.c
> @@ -289,7 +289,7 @@ static int lpc18xx_pwm_request(struct pw
> dev_err(lpc18xx_pwm->dev,
> "maximum number of simultaneous channels reached\n");
> return -EBUSY;
> - };
> + }
>
> set_bit(event, &lpc18xx_pwm->event_map);
> lpc18xx_data->duty_event = event;
>

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature