Re: [PATCH V6 2/6] scripts: dtc: Build fdtoverlay tool

From: Viresh Kumar
Date: Fri Jan 29 2021 - 01:12:42 EST


On 29-01-21, 00:03, Frank Rowand wrote:
> On 1/22/21 4:50 AM, Viresh Kumar wrote:
> > We will start building overlays for platforms soon in the kernel and
> > would need fdtoverlay going forward. Lets start building it.
> >
> > The fdtoverlay program applies (or merges) one or more overlay dtb
> > blobs to a base dtb blob. The kernel build system would later use
> > fdtoverlay to generate the overlaid blobs based on platform specific
> > configurations.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> > ---
> > scripts/dtc/Makefile | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/scripts/dtc/Makefile b/scripts/dtc/Makefile
> > index 4852bf44e913..5f19386a49eb 100644
> > --- a/scripts/dtc/Makefile
> > +++ b/scripts/dtc/Makefile
> > @@ -1,13 +1,17 @@
> > # SPDX-License-Identifier: GPL-2.0
> > # scripts/dtc makefile
> >
> > -hostprogs-always-$(CONFIG_DTC) += dtc
> > +hostprogs-always-$(CONFIG_DTC) += dtc fdtoverlay
> > hostprogs-always-$(CHECK_DT_BINDING) += dtc
> >
> > dtc-objs := dtc.o flattree.o fstree.o data.o livetree.o treesource.o \
> > srcpos.o checks.o util.o
> > dtc-objs += dtc-lexer.lex.o dtc-parser.tab.o
> >
>
> Please add this comment:
>
> # The upstream project builds libfdt as a separate library. We are choosing to
> # instead directly link the libfdt object files into fdtoverly

My bad, I checked this again and you gave the exact same comment
during V4 as well. Sorry about missing this earlier.

--
viresh