Re: [PATCH v2] kretprobe: avoid re-registration of the same kretprobe earlier

[Steven Rostedt]

On Fri, 29 Jan 2021 15:23:47 +0530
"Naveen N. Rao" <naveen.n.rao@xxxxxxxxxxxxxxxxxx> wrote:

> diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> index f7fb5d135930fa..63a36f33565354 100644
> --- a/kernel/kprobes.c
> +++ b/kernel/kprobes.c
> @@ -1530,6 +1530,7 @@ static inline int check_kprobe_rereg(struct kprobe *p)
>                 ret = -EINVAL;
>         mutex_unlock(&kprobe_mutex);
> 
> +       WARN_ON(ret);
>         return ret;
>  }

Please use WARN_ON_ONCE(ret);

Thanks,

-- Steve