Re: [PATCH v9 3/4] kasan: Add report for async mode
From: Vincenzo Frascino
Date: Fri Jan 29 2021 - 13:43:39 EST
Hi Andrey,
On 1/29/21 6:16 PM, Vincenzo Frascino wrote:
> What I meant is instead of:
>
> if (addr) trace_error_report_end(...);
>
> you might want to do:
>
> if (!IS_ENABLED(CONFIG_KASAN_HW_TAGS)) trace_error_report_end(...);
>
> because, could make sense to trace 0 in other cases?
>
> I could not find the implementation of trace_error_report_end() hence I am not
> really sure on what it does.
I figured it out how trace_error_report_end() works. And in doing that I
realized that the problem is sync vs async, hence I agree with what you are
proposing:
if (addr) trace_error_report_end(...);
I will post v10 shortly. If we want to trace the async mode we can improve it in
-rc1.
--
Regards,
Vincenzo