Re: [5.11 regression] "tty: implement write_iter" breaks TIOCCONS

[Hans de Goede]

Hi,

On 1/29/21 9:28 PM, Linus Torvalds wrote:
> On Fri, Jan 29, 2021 at 12:02 PM Linus Torvalds
> <torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>>
>> It's fairly easy to work around in this in the tty layer by just
>> avoiding that function entirely, so I'll cook up a patch to do that.
>> But I'm adding the appropriate people to the participants here because
>> this really is very subtle if you ever hit it.
> 
> Here's the patch to make the tty layer just do the redirection
> entirely internally, avoiding that mis-designed vfs_iocb_iter_write()
> function.
> 
> Hans, does this fix things for you? I'm pretty confident it will, but
> always best to double-check..

I can confirm that the attached patch fixes things for me, thanks.

Regards,

Hans