Re: [PATCH v3 2/5] x86/sgx: Optimize the locking range in sgx_sanitize_section()

From: Jarkko Sakkinen
Date: Sat Jan 30 2021 - 08:26:19 EST


On Sun, Jan 24, 2021 at 02:29:04PM +0800, Tianjia Zhang wrote:
> The spin lock of sgx_epc_section only locks the page_list. The
> EREMOVE operation and init_laundry_list is not necessary in the
> protection range of the spin lock. This patch reduces the lock
> range of the spin lock in the function sgx_sanitize_section()
> and only protects the operation of the page_list.
>
> Suggested-by: Sean Christopherson <seanjc@xxxxxxxxxx>
> Signed-off-by: Tianjia Zhang <tianjia.zhang@xxxxxxxxxxxxxxxxx>

I prefer to use the word "optimize" only if there is supporting
data to show that the code change has significant value.

/Jarkko