Re: [PATCH] mm/swap_state: Constify static struct attribute_group

[Amy Parker]

On Mon, Feb 1, 2021 at 3:37 PM Rikard Falkeborn
<rikard.falkeborn@xxxxxxxxx> wrote:
>
> The only usage of swap_attr_group is to pass its address to
> sysfs_create_group() which takes a pointer to const attribute_group.
> Make it const to allow the compiler to put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@xxxxxxxxx>
> ---
>  mm/swap_state.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/swap_state.c b/mm/swap_state.c
> index d0d417efeecc..3cdee7b11da9 100644
> --- a/mm/swap_state.c
> +++ b/mm/swap_state.c
> @@ -901,7 +901,7 @@ static struct attribute *swap_attrs[] = {
>         NULL,
>  };
>
> -static struct attribute_group swap_attr_group = {
> +static const struct attribute_group swap_attr_group = {
>         .attrs = swap_attrs,
>  };
>
> --
> 2.30.0
>

Looks all good to me - there aren't any dependencies on it anywhere else.

Reviewed-by: Amy Parker <enbyamy@xxxxxxxxx>