Re: 5.11 new lockdep warning related to led-class code (also may involve ata / piix controller)

[Hans de Goede]

Hi,

On 2/2/21 10:32 AM, Pavel Machek wrote:
> Hi!
> 
>>> Is it a regression? AFAIK it is a bug that has been there
>>> forever... My original plan was to simply wait for 5.12, so it gets
>>> full release of testing...
>>
>> It may have been a pre-existing bug which got triggered by libata
>> changes?
> 
> Fixes tag suggests it is rather old.
> 
>> I don't know. I almost always run all my locally build kernels with lockdep
>> enabled and as the maintainer of the vboxvideo, vboxguest and vboxsf guest
>> drivers in the mainline kernel I quite often boot local build kernels inside
>> a vm.
>>
>> So I believe that lockdep tripping over this is new in 5.11, which is why
>> I called it a regression.
>>
>> And the fix seems very safe and simple, so IMHO it would be good to get
>> this into 5.11
> 
> It is in 5.11 now, and also -stable kernels. (Which suprised me a
> bit).
> 
> Testing would be welcome.

I've been running my locally build kernels with this patch added for
a while now. Including inside VirtualBox where the bug triggered before.

I've not seen any bad side-effects from having this patch in my local
kernels and I can confirm that it fixes the issue which I was seeing.

Regards,

Hans