Re: [PATCH v5 0/4] perf vendor events: Support PMU events for A64FX

[John Garry]

On 02/02/2021 12:51, Shunsuke Nakamura wrote:
> From: Shunsuke Nakamura <nakamura.shun@xxxxxxxxxxx>
>
> This patch series supports A64FX PMU event v1.2.
>
> The first patch adds a common and microarchitecture event, which can be
> referenced from CPU JSONs.
> This patch uses part of John's patch.[1]
>
> The second patch add more common and microarchitecture events.
>
> The third patch fixes the lexical definition of event name so that
> perf can recognize event name that start with a number.
>
> The fourth patch adds PMU events for A64FX.

Just some things to note:
- please pick up and apply reviewed-by tags granted from previous 
reviews if explicitly granted, subject to making any trivial changes 
requested
If any significant changes are made, then don't pick up theses tags or 
drop them (if they were picked up earlier)
- I'd say that it's best not to send my patch in 1/4, but better to 
mention the series which this is based on in your cover letter
Sending my patch is only going to make the maintainers (Arnaldo) life 
more difficult to track these things.

Apart from that, I think that we're a bit uncertain about patch 3/4

Thanks,
john


> Changes in v4:
>   - Add arm64 to the subjects of the second and fourth patches.
>   - Add reference URLs to the body of the second patch.
>
> Changes in v3:
>   - Add linux-arm-kernel mailing list to cc.
>
> Changes in v2:
>   - Added armv8-common-and-microarch based on John's patch.[1]
>   - Fixed A64FX Json to refer to standard events in armv8-common-and-microarch.
>
>
> [1] https://lore.kernel.org/lkml/1611835236-34696-3-git-send-email-john.garry@xxxxxxxxxx/
>
>
> John Garry (1):
>    perf vendor events arm64: Add common and uarch event JSON
>
> Shunsuke Nakamura (3):
>    perf vendor events arm64: Add common and uarch event JSON
>    perf vendor events arm64: Add more common and uarch events
>    perf tools: Fix lexical definition of event name
>    perf vendor events arm64: Add Fujitsu A64FX pmu event
>
>   .../arch/arm64/armv8-common-and-microarch.json     | 476 +++++++++++++++++++++
>   .../arch/arm64/fujitsu/a64fx/branch.json           |   8 +
>   .../pmu-events/arch/arm64/fujitsu/a64fx/bus.json   |  62 +++
>   .../pmu-events/arch/arm64/fujitsu/a64fx/cache.json | 128 ++++++
>   .../pmu-events/arch/arm64/fujitsu/a64fx/cycle.json |   5 +
>   .../arch/arm64/fujitsu/a64fx/exception.json        |  29 ++
>   .../arch/arm64/fujitsu/a64fx/instruction.json      | 131 ++++++
>   .../arch/arm64/fujitsu/a64fx/memory.json           |   8 +
>   .../pmu-events/arch/arm64/fujitsu/a64fx/other.json | 188 ++++++++
>   .../arch/arm64/fujitsu/a64fx/pipeline.json         | 194 +++++++++
>   .../pmu-events/arch/arm64/fujitsu/a64fx/sve.json   | 110 +++++
>   tools/perf/pmu-events/arch/arm64/mapfile.csv       |   1 +
>   tools/perf/util/parse-events.l                     |   2 +-
>   13 files changed, 1341 insertions(+), 1 deletion(-)
>   create mode 100644 tools/perf/pmu-events/arch/arm64/armv8-common-and-microarch.json
>   create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/branch.json
>   create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/bus.json
>   create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/cache.json
>   create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/cycle.json
>   create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/exception.json
>   create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/instruction.json
>   create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/memory.json
>   create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/other.json
>   create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/pipeline.json
>   create mode 100644 tools/perf/pmu-events/arch/arm64/fujitsu/a64fx/sve.json