Re: [PATCH v1] leds: lp50xx: add setting of default intensity from DT

[Pavel Machek]

Hi!

> > > If I would not have the default-intensity I would actually see nothing,
> > > since the intensity (which goes from 0-255) of each led is initialized with 0.
> > > 
> > > I hope I could clarify this a little more?  
> > 
> > Yes, sounds reasonable. Could we get default intensity of 100% on all
> > channels if nothing else is specified?
> > 
> > Or maybe simply "if intensity is not specified, start with 100%, and
> > use explicit =0 if other color is expected".
> > 
> > Best regards,
> > 								Pavel
> 
> Is the property default-intensity documented in DT bindings?
> 
> Wouldn't it be better if the property was used in the multi-led node
> instead of the channel node? I.e.
>   multi-led@3 {
>     color = <LED_COLOR_ID_RGB>;
>     default-intensity = <100 0 0>;
>   };

Yes, this would be better.

-- 
http://www.livejournal.com/~pavelmachek

Attachment: signature.asc
Description: PGP signature