Re: [PATCH] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed

From: Kees Cook
Date: Wed Feb 03 2021 - 13:55:33 EST


On Tue, Feb 02, 2021 at 02:51:00PM -0800, Linus Torvalds wrote:
> On Tue, Feb 2, 2021 at 2:34 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> >
> > "I also suspect that everybody has already accepted that KASLR isn't
> > really working locally anyway (due to all the hw leak models with
> > cache and TLB timing), so anybody who can look at kernel messages
> > already probably could figure most of those things out."
>
> Honestly, if you have to pass a kernel command line, and there's a big
> notice in the kernel messages about this, I no longer care.

Okay, cool; it's fine by me too. I prefer this kind of "boot into debug
mode" switch to having lots of %px scattered around in questionable
places. :)

I will update the %p deprecation docs.

--
Kees Cook