Re: [PATCH v3] drm/panel: simple: add SGD GKTW70SDAD1SD

From: Fabio Estevam
Date: Thu Feb 04 2021 - 13:24:15 EST


Hi Oliver,

On Tue, Feb 2, 2021 at 2:35 PM Oliver Graute <oliver.graute@xxxxxxxxx> wrote:

> +static const struct panel_desc sgd_gktw70sdad1sd = {
> + .timings = &sgd_gktw70sdad1sd_timing,
> + .num_timings = 1,
> + .bpc = 6,
> + .size = {
> + .width = 153,
> + .height = 86,
> + },
> + .delay = {
> + .prepare = 20 + 20 + 10 + 10,

Adding the datasheet label like Marco suggested make it clearer where
these numbers come from : /* T0 + T2 + T3 + T4 */

Glad you got it working on your imx6ul board:

Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>