Re: [PATCH v4 3/3] arm64: dts: reset: add microchip sparx5 switch reset driver

From: Rob Herring
Date: Mon Feb 08 2021 - 13:53:38 EST


On Mon, Feb 8, 2021 at 7:20 AM Steen Hegelund
<steen.hegelund@xxxxxxxxxxxxx> wrote:
>
> Hi Rob,
>
> On Fri, 2021-02-05 at 16:35 -0600, Rob Herring wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > know the content is safe
> >
> > On Wed, Jan 20, 2021 at 09:19:21AM +0100, Steen Hegelund wrote:
> > > This provides reset driver support for the Microchip Sparx5 PCB134
> > > and
> > > PCB135 reference boards.
> >
> > This isn't a compatible change. You need an explanation why that's
> > okay
> > if that's intended.
>
> I am not entirely sure that I get your point.
>
> The change (adding the reset driver) is new, and it is optional (but
> strongly recommended) for the clients to use it, so will this be a
> incompatible change?

I'm assuming something used "microchip,sparx5-chip-reset"?

> I can certainly add a an explanation. Would that be needed here in the
> bindings, or where do you suggest?

Just need to spell out why dropping that is okay in the commit msg.
But I guess what this looks like will change anyways.

Rob