Re: [PATCH V7 6/6] of: unittest: Statically apply overlays using fdtoverlay

From: Viresh Kumar
Date: Tue Feb 09 2021 - 05:25:24 EST


On 08-02-21, 08:21, Rob Herring wrote:
> We may need to turn off
> checks in overlays for required properties as they may be incomplete.
> We already do that on disabled nodes.

And after decent amount of effort understanding how to do this, I
finally did it in a not so efficient way, I am sure you can help
improving it :)

Author: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
Date: Tue Feb 9 12:19:50 2021 +0530

dt-validate: Skip "required property" checks for overlays

The overlays may not carry the required properties and would depend on
the base dtb to carry those, there is no point raising those errors
here.

Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
---
tools/dt-validate | 17 +++++++++++++++++
1 file changed, 17 insertions(+)

diff --git a/tools/dt-validate b/tools/dt-validate
index 410b0538ef47..c6117504f1d1 100755
--- a/tools/dt-validate
+++ b/tools/dt-validate
@@ -80,6 +80,23 @@ show_unmatched = False
(filename, line, col, fullname, node['compatible']), file=sys.stderr)
continue

+ if nodename == '/':
+ is_fragment = False
+ for name in node.items():
+ if name[0] == 'fragment@0':
+ is_fragment = True
+ break;
+
+ if is_fragment == True:
+ if 'required property' in error.message:
+ continue
+ elif error.context:
+ for e in error.context:
+ if not 'required property' in e.message:
+ break
+ else:
+ continue
+
print(dtschema.format_error(filename, error, nodename=nodename, verbose=verbose) +
'\n\tFrom schema: ' + schema['$filename'],
file=sys.stderr)

--
viresh