Re: [PATCH v1 2/2] ACPI: OSL: Clean up printing messages

From: Rafael J. Wysocki
Date: Tue Feb 09 2021 - 09:56:36 EST


On Mon, Feb 8, 2021 at 9:49 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Mon, 2021-02-08 at 19:59 +0100, Rafael J. Wysocki wrote:
> > Replace the ACPI_DEBUG_PRINT() instance in osl.c unrelated to the
> > ACPICA debug with acpi_handle_debug(), add a pr_fmt() definition
> > to osl.c and replace direct printk() usage in that file with the
> > suitable pr_*() calls.
> []
> > ===================================================================
> > --- linux-pm.orig/drivers/acpi/osl.c
> > +++ linux-pm/drivers/acpi/osl.c
> []
> > @@ -528,13 +531,13 @@ acpi_os_predefined_override(const struct
> >
> >
> > *new_val = NULL;
> > if (!memcmp(init_val->name, "_OS_", 4) && strlen(acpi_os_name)) {
> > - printk(KERN_INFO PREFIX "Overriding _OS definition to '%s'\n",
> > + pr_info("Overriding _OS definition to '%s'\n",
> > acpi_os_name);
>
> If you do more of these, perhaps rewrap lines to 80 columns when possible.
>
> pr_info("Overriding _OS definition to '%s'\n", acpi_os_name);
>
> etc...

I've overlooked this one, will fix it up in the final commit.

Thanks!