Re: [PATCH v10 2/7] i2c: Allow an ACPI driver to manage the device's power state during probe

From: Sakari Ailus
Date: Wed Feb 10 2021 - 17:30:24 EST


On Tue, Feb 09, 2021 at 10:04:10PM +0100, Wolfram Sang wrote:
>
> > + * @I2C_DRV_FL_ALLOW_LOW_POWER_PROBE: Let the ACPI driver manage the device's
> > + * power state during probe and remove
>
> Well, for the functional change, I am happy if the ACPI guys are happy.
> The only minor nit for me would be removing the "_FL" snipplet from the

I'm actually renaming this as I2C_DRV_ACPI_WAIVE_D0_PROBE, with similar
changes to the function names. I opportunistically assume the ack holds
still. :-) I'll post v11 soon.

> name of the define because I think it is clear enough that this is a
> flag. If you need to resend anyhow, maybe it is worth a thought. It is
> not a big issue, so anyway:
>
> Acked-by: Wolfram Sang <wsa@xxxxxxxxxx>
>
> because I assume this will go in via the ACPI tree?
>

--
Sakari Ailus