Re: [PATCH v5 04/15] PCI: Add pci_find_vsec_capability() to find a specific VSEC

From: Krzysztof Wilczyński
Date: Thu Feb 11 2021 - 08:12:17 EST


Hi Gustavo,

[...]
> + * Typically this function will be called by the pci driver, which passes

It would be "PCI" here.

> + * through argument the 'struct pci_dev *' already pointing for the device
> + * config space that is associated with the vendor and device ID which will
> + * know which ID to search and what to do with it, however, it might be

Probably "there might be".

> + * cases that this function could be called outside of this scope and
> + * therefore is the caller responsibility to check the vendor and/or
[...]

A suggestion. This commit message is a little hard to read and could be
improved.

It might just be me (by and large, and I am not a native English
speaker), but it's actually easier to figure out what the function does
after reading the implementation that from the comment. :)

Krzysztof