Re: [PATCH 13/16] media: i2c: rdacm2x: Implement .init() subdev op

From: Geert Uytterhoeven
Date: Wed Feb 17 2021 - 03:18:23 EST


On Tue, Feb 16, 2021 at 6:41 PM Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> wrote:
> The current probe() procedure of the RDACM20 and RDACM20 performs
> initialization of the serializer image sensors and increases the noise
> immunity threshold as last operation, which is then compensated by the
> remote deserializer by increasing the reverse channel signal amplitude
> once all remotes have bound.
>
> The probe routine is then run without noise immunity activated which
> in noisy environment conditions makes the probe sequence less reliable as
> the chips configuration requires a relevant amount of i2c transactions.
>
> Break chip initialization in two:
> - At probe time only configure the serializer's reverse channel with
> noise immunity activated, to reduce the number of transactions

deactivated?

> performed without noise immunity protection
> - Move the chips initialization to the .init() core subdev operation to
> be invoked by the deserializer after the camera has probed and it has
> increased the reverse channel amplitude
>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds