Re: [PATCH 1/3] Input: applespi: Don't wait for responses to commands indefinitely.

From: Life is hard, and then you die
Date: Wed Feb 17 2021 - 15:52:48 EST



Hi Dmitry,

On Wed, Feb 17, 2021 at 12:23:23PM -0800, Dmitry Torokhov wrote:
>
> On Wed, Feb 17, 2021 at 11:07:16AM -0800, Ronald Tschalär wrote:
> > @@ -869,7 +878,7 @@ static int applespi_send_cmd_msg(struct applespi_data *applespi)
> > return sts;
> > }
> >
> > - applespi->cmd_msg_queued = true;
> > + applespi->cmd_msg_queued = ktime_get();
>
> Will it be OK if I change this to ktime_get_coarse()? I do not think we
> need exact time here, and the coarse variant is cheaper I believe.

Certainly - I just wasn't aware of the coarse variant.


Cheers,

Ronald