Re: [PATCH v4] printk: Userspace format enumeration support

From: Chris Down
Date: Thu Feb 18 2021 - 13:21:17 EST


Petr Mladek writes:
On Thu 2021-02-18 12:41:39, Chris Down wrote:
Petr Mladek writes:
> > - See if it's safe to pass a printk_fmt_sec to seq_file instead of a module
>
> Also it might be needed to store the pointer to struct module.

You mean, have a `struct module` entry for this? I somewhat suspect that
module.c maintainers are not likely to be happy about injecting non-generic
code into there if it's possible to be avoided, but maybe I'm
misunderstanding?

Yes, I suggest to store the pointer into struct module. It includes
many external entries. It is similar to struct task_struct.

Ah yes, now you mention it that does look fine. Thanks!

Expect v5 in the coming days, then. :-)