RE: [PATCH] staging: comedi: cast to (unsigned int *)

From: David Laight
Date: Fri Feb 19 2021 - 04:09:22 EST


> It's kind of moot anyway because the patch is outdated. But the reason
> for the ___force is that the same `struct comedi_cmd` is used in both
> user and kernel contexts. In user contexts, the `chanlist` member
> points to user memory and in kernel contexts it points to kernel memory
> (copied from userspace).

Can't you use a union of the user and kernel pointers?
(Possibly even anonymous?)
Although, ideally, keeping them in separate fields is better.
8 bytes for a pointer isn't going make a fat lot of difference.

David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)