Re: [PATCH v7 0/5] Add initial support for ATC260x PMICs

From: Lee Jones
Date: Mon Feb 22 2021 - 04:13:12 EST


On Sun, 21 Feb 2021, Cristian Ciocaltea wrote:

> Hi Lee,
>
> I have just noticed your mfd-next tag for 5.12 doesn't include the
> support for the ATC260x PMICs.
>
> I assumed the patchset is ready for merging.. Did I miss something?

The MFD driver needs another review.

For some reason, this didn't register on my TODO list.

In general, if you don't receive a review within ~2 weeks of posting
(and the merge window is not open), you should consider it lost and
submit a [RESEND].

> On Tue, Jan 26, 2021 at 11:55:56AM +0200, Cristian Ciocaltea wrote:
> > The ATC260x family of PMICs integrates Audio Codec, Power management,
> > Clock generation and GPIO controller blocks. There are currently 3
> > variants: ATC2603A, ATC2603C and ATC2609A.
> >
> > This is re-spin of the v1 patch series submitted some time ago by
> > Mani, who provided the MFD and regulator drivers for ATC2609A:
> > https://lore.kernel.org/lkml/20190617155011.15376-1-manivannan.sadhasivam@xxxxxxxxxx/
> >
> > Since v2, I added support for ATC2603C, together with some new
> > functionalities for both chips: power controller and onkey input.
> > The ATC2603A chip type remains unsupported for the moment.
> >
> > This has been tested on RoseapplePi, a SBC based on the Actions Semi S500
> > SoC, which integrates the ATC2603C variant of the PMIC.
> >
> > Note that enabling the ATC260x PMICs on compatible Actions Semi Owl SoC
> > based boards depends on:
> >
> > * the Actions Semi SIRQ driver (for PMIC DTS setup), merged in v5.10:
> > https://lore.kernel.org/lkml/cover.1600114378.git.cristian.ciocaltea@xxxxxxxxx/
> >
> > * the atomic transfers in Owl I2C driver (for power controller), merged in v5.11:
> > https://lore.kernel.org/lkml/cover.1602190168.git.cristian.ciocaltea@xxxxxxxxx/

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog