Re: [PATCH v6 0/2] add support for GPIO or IRQ based evemt counter

From: William Breathitt Gray
Date: Tue Feb 23 2021 - 03:15:31 EST


On Tue, Feb 23, 2021 at 08:16:30AM +0100, Oleksij Rempel wrote:
> Hi William,
>
> On Mon, Feb 22, 2021 at 10:48:56AM +0900, William Breathitt Gray wrote:
> > On Tue, Feb 16, 2021 at 09:13:54AM +0100, Oleksij Rempel wrote:
> > > changes v6:
> > > - rename it to interrupt-counter
> >
> > Hi Oleksij,
> >
> > Sorry to nitpick again, I think "irq-counter" as Jonathan suggested in
> > an earlier review would be a better name afterall. Would you be able to
> > rename this driver to use that name instead?
>
> I would prefer not to rename it. IRQ (Interrupt Request) is a signal
> outside of the system. Below some frequency rate, amount of counted
> ISR (interrupt service routine) calls or events would be equal to the actual
> IRQs. If frequency is too high, we will count ISR, but not IRQs. In
> any case, interrupt-counter is more or leas neutral, without triggering
> too many wrong assumptions.
>
> Regards,
> Oleksij
> --
> Pengutronix e.K. | |
> Steuerwalder Str. 21 | http://www.pengutronix.de/ |
> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

I suppose "interrupt-counter" should be fine in this context then, so
perhaps a rename isn't really necessary afterall.

William Breathitt Gray

Attachment: signature.asc
Description: PGP signature