Re: [PATCH] mtd: rawnand: qcom: Convert nandc to chip in Read/Write helper

From: Miquel Raynal
Date: Tue Feb 23 2021 - 11:10:57 EST


Hello,

Md Sadre Alam <mdalam@xxxxxxxxxxxxxx> wrote on Mon, 22 Feb 2021
01:55:01 +0530:

> This change will convert nandc to chip in Read/Write helper, this
> change is needed because if we wnated to access number of steps
> in Read/Write helper then we need to get the chip->ecc.steps,
> currentlly its not possible.After this change we can directly
> acces chip->ecc.steps in Read/Write helper.
>
> Signed-off-by: Md Sadre Alam <mdalam@xxxxxxxxxxxxxx>

Thanks for splitting your series, I think it's much easier to review
and contains much less imprecise changes.

I have a few minor comments (see the following e-mails), please address
them and then please send all your patches a single series, not like 6+
independent patches.

I'll then require someone to test it if we are good I'll merge it.

Thanks,
Miquèl