Re: [PATCH] lib: vsprintf: check for NULL device_node name in device_node_string()

From: Enrico Weigelt, metux IT consult
Date: Tue Feb 23 2021 - 15:10:09 EST


On 17.02.21 14:50, Andy Shevchenko wrote:
On Wed, Feb 17, 2021 at 01:15:43PM +0100, Enrico Weigelt, metux IT consult wrote:
Under rare circumstances it may happen that a device node's name is NULL
(most likely kernel bug in some other place).

What circumstances? How can I reproduce this? More information, please!

Observed it when applying a broken overlay. (sorry, didn't keep that
broken code :o). In this case, the device_node was left without a name
(pointing to NULL).

+ pr_warn("device_node without name. Kernel bug ?\n");

If it's not once, then it's possible to have log spammed with this, right?

It only has occoured once for me. I don't think spamming could happen,
unless one's hacking deeply in the oftree code.

+ p = "<NULL>";

We have different standard de facto for NULL pointers to be printed. Actually
if you wish, you may gather them under one definition (maybe somewhere under
printk) and export to everybody to use.

Seen it in Petr's reply ... going to use that in v2.

--mtx

--
---
Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert
werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren
GPG/PGP-Schlüssel zu.
---
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@xxxxxxxxx -- +49-151-27565287