Re: [PATCH] dt-bindings: spi: Convert NXP flexspi to json schema

From: Rob Herring
Date: Mon Mar 01 2021 - 09:45:24 EST


On Mon, 01 Mar 2021 15:34:06 +0530, Kuldeep Singh wrote:
> Convert the NXP FlexSPI binding to DT schema format using json-schema.
> Also, update MAINTAINERS to reflect the change.
>
> Signed-off-by: Kuldeep Singh <kuldeep.singh@xxxxxxx>
> ---
> .../bindings/spi/nxp,spi-nxp-fspi.yaml | 101 ++++++++++++++++++
> .../devicetree/bindings/spi/spi-nxp-fspi.txt | 42 --------
> MAINTAINERS | 2 +-
> 3 files changed, 102 insertions(+), 43 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml
> delete mode 100644 Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
>

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml: properties:clocks:maxItems: False schema does not allow 2
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml: ignoring, error in schema: properties: clocks: maxItems
warning: no schema found in file: ./Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml
Error: Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.example.dts:26.31-32 syntax error
FATAL ERROR: Unable to parse input tree
make[1]: *** [scripts/Makefile.lib:349: Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.example.dt.yaml] Error 1
make: *** [Makefile:1380: dt_binding_check] Error 2

See https://patchwork.ozlabs.org/patch/1445509

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.