Re: [PATCH v3 2/8] mm/swapops: Rework swap entry manipulation code

From: Jason Gunthorpe
Date: Mon Mar 01 2021 - 18:05:23 EST


On Fri, Feb 26, 2021 at 06:18:26PM +1100, Alistair Popple wrote:
> Both migration and device private pages use special swap entries which
> are manipluated by a range of inline functions. The arguments to these
> are somewhat inconsitent so rework them to remove flag type arguments
> and to make the arguments similar for both a read and write entry
> creation.
>
> Signed-off-by: Alistair Popple <apopple@xxxxxxxxxx>
> ---
> include/linux/swapops.h | 56 ++++++++++++++++++++++-------------------
> mm/debug_vm_pgtable.c | 12 ++++-----
> mm/hmm.c | 2 +-
> mm/huge_memory.c | 26 +++++++++++++------
> mm/hugetlb.c | 10 +++++---
> mm/memory.c | 10 +++++---
> mm/migrate.c | 26 ++++++++++++++-----
> mm/mprotect.c | 10 +++++---
> mm/rmap.c | 10 +++++---
> 9 files changed, 100 insertions(+), 62 deletions(-)


Reviewed-by: Jason Gunthorpe <jgg@xxxxxxxxxx>