Re: [PATCH] tpm: Remove unintentional dump_stack() call

From: Rikard Falkeborn
Date: Tue Mar 02 2021 - 02:09:16 EST


On Mon, Mar 01, 2021 at 11:44:09AM +0200, jarkko@xxxxxxxxxx wrote:
> From: Jarkko Sakkinen <jarkko@xxxxxxxxxx>
>
> Somewhere along the line, probably during a rebase, an unintentional
> dump_stack() got included. Revert this change.
>
> Reported-by: Rikard Falkeborn <rikard.falkeborn@xxxxxxxxx>
> Fixes: 90cba8d20f8b ("tpm/ppi: Constify static struct attribute_group")
> Signed-off-by: Jarkko Sakkinen <jarkko@xxxxxxxxxx>
> ---
> drivers/char/tpm/tpm-chip.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c
> index 19e23fcc6bc8..ddaeceb7e109 100644
> --- a/drivers/char/tpm/tpm-chip.c
> +++ b/drivers/char/tpm/tpm-chip.c
> @@ -278,8 +278,6 @@ static void tpm_devs_release(struct device *dev)
> {
> struct tpm_chip *chip = container_of(dev, struct tpm_chip, devs);
>
> - dump_stack();
> -
> /* release the master device reference */
> put_device(&chip->dev);
> }
> --
> 2.30.1
>

Acked-by: Rikard Falkeborn <rikard.falkeborn@xxxxxxxxx>