Re: [PATCH] ASoC: codec: Omit superfluous error message injz4760_codec_probe()

[tangbin]

Hi Paul:

On 2021/3/2 20:23, Paul Cercueil wrote:
> Hi Tang,
>
> Le mar. 2 mars 2021 à 20:11, Tang Bin <tangbin@xxxxxxxxxxxxxxxxxxxx> a 
> écrit :
> > The function devm_platform_ioremap_resource has already contained error
> > message, so remove the redundant dev_err here.
> >
> > Signed-off-by: Tang Bin <tangbin@xxxxxxxxxxxxxxxxxxxx>
> > ---
> >  sound/soc/codecs/jz4760.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/sound/soc/codecs/jz4760.c b/sound/soc/codecs/jz4760.c
> > index e8f28ccc145a..c2d8a107f159 100644
> > --- a/sound/soc/codecs/jz4760.c
> > +++ b/sound/soc/codecs/jz4760.c
> > @@ -843,7 +843,6 @@ static int jz4760_codec_probe(struct 
> > platform_device *pdev)
> >      codec->base = devm_platform_ioremap_resource(pdev, 0);
> >      if (IS_ERR(codec->base)) {
> >          ret = PTR_ERR(codec->base);
> > -        dev_err(dev, "Failed to ioremap mmio memory: %d\n", ret);
> >          return ret;
> >      }
>
> Indeed, you are right.
>
> I guess you do this instead:
>
> if (IS_ERR(codec->base))
>    return PTR_ERR(codec->base);

Yes, I would have written it in your ways, but considered the variable 
"ret", I gave up, and just deleted dev_err().


Thanks

Tang Bin