Re: [PATCH] crypto: sun8i-ss: Fix memory leak of object d when dma_iv fails to map

From: Corentin Labbe
Date: Tue Mar 02 2021 - 14:31:46 EST


Le Tue, Mar 02, 2021 at 04:34:46PM +0000, Colin King a écrit :
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> In the case where the dma_iv mapping fails, the return error path leaks
> the memory allocated to object d. Fix this by adding a new error return
> label and jumping to this to ensure d is free'd before the return.
>
> Addresses-Coverity: ("Resource leak")
> Fixes: ac2614d721de ("crypto: sun8i-ss - Add support for the PRNG")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---

Acked-by: Corentin Labbe <clabbe.montjoie@xxxxxxxxx>

Thanks!