Re: [PATCH v3 01/25] mm: Introduce struct folio

[Zi Yan]

On 2 Mar 2021, at 8:22, Matthew Wilcox wrote:

> On Mon, Mar 01, 2021 at 03:26:11PM -0500, Zi Yan wrote:
>>> +static inline struct folio *next_folio(struct folio *folio)
>>> +{
>>> +	return folio + folio_nr_pages(folio);
>>
>> Are you planning to make hugetlb use folio too?
>>
>> If yes, this might not work if we have CONFIG_SPARSEMEM && !CONFIG_SPARSEMEM_VMEMMAP
>> with a hugetlb folio > MAX_ORDER, because struct page might not be virtually contiguous.
>> See the experiment I did in [1].
>
> Actually, how about proofing this against a future change?
>
> static inline struct folio *next_folio(struct folio *folio)
> {
> #if defined(CONFIG_SPARSEMEM) && !defined(CONFIG_SPARSEMEM_VMEMMAP)
> 	pfn_t next_pfn = page_to_pfn(&folio->page) + folio_nr_pages(folio);
> 	return (struct folio *)pfn_to_page(next_pfn);
> #else
> 	return folio + folio_nr_pages(folio);
> #endif
> }
>
> (not compiled)

Yes, it should work. A better version might be that in the top half
you check folio order first and if the order >= MAX_ORDER, we use
the complicated code, otherwise just folio+folio_nr_pages(folio).

This CONFIG_SPARSEMEM && !CONFIG_SPARSEMEM_VMEMMAP is really not friendly
to >=MAX_ORDER pages. Most likely I am going to make 1GB THP
rely on CONFIG_SPARSEMEM_VMEMMAP to avoid complicated code.

—
Best Regards,
Yan Zi

Attachment: signature.asc
Description: OpenPGP digital signature