drivers/soc/mediatek/mtk-pm-domains.c:492 scpsys_add_subdomain() warn: missing error code 'ret'

From: Dan Carpenter
Date: Wed Mar 03 2021 - 07:00:06 EST

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7a7fd0de4a9804299793e564a555a49c1fc924cb
commit: dd65030295e20338bbb8238454c2e9546b6e5e17 soc: mediatek: pm-domains: Don't print an error if child domain is deferred
config: nds32-randconfig-m031-20210302 (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

smatch warnings:
drivers/soc/mediatek/mtk-pm-domains.c:492 scpsys_add_subdomain() warn: missing error code 'ret'

vim +/ret +492 drivers/soc/mediatek/mtk-pm-domains.c

59b644b01cf48d Enric Balletbo i Serra 2020-10-30 465 static int scpsys_add_subdomain(struct scpsys *scpsys, struct device_node *parent)
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 466 {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 467 struct generic_pm_domain *child_pd, *parent_pd;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 468 struct device_node *child;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 469 int ret;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 470
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 471 for_each_child_of_node(parent, child) {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 472 u32 id;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 473
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 474 ret = of_property_read_u32(parent, "reg", &id);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 475 if (ret) {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 476 dev_err(scpsys->dev, "%pOF: failed to get parent domain id\n", child);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 477 goto err_put_node;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 478 }
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 479
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 480 if (!scpsys->pd_data.domains[id]) {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 481 ret = -EINVAL;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 482 dev_err(scpsys->dev, "power domain with id %d does not exist\n", id);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 483 goto err_put_node;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 484 }
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 485
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 486 parent_pd = scpsys->pd_data.domains[id];
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 487
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 488 child_pd = scpsys_add_one_domain(scpsys, child);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 489 if (IS_ERR(child_pd)) {
dd65030295e203 Enric Balletbo i Serra 2021-01-13 490 dev_err_probe(scpsys->dev, PTR_ERR(child_pd),
dd65030295e203 Enric Balletbo i Serra 2021-01-13 491 "%pOF: failed to get child domain id\n", child);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 @492 goto err_put_node;

err = PTR_ERR(child_pd);

59b644b01cf48d Enric Balletbo i Serra 2020-10-30 493 }
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 494
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 495 ret = pm_genpd_add_subdomain(parent_pd, child_pd);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 496 if (ret) {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 497 dev_err(scpsys->dev, "failed to add %s subdomain to parent %s\n",
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 498 child_pd->name, parent_pd->name);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 499 goto err_put_node;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 500 } else {
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 501 dev_dbg(scpsys->dev, "%s add subdomain: %s\n", parent_pd->name,
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 502 child_pd->name);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 503 }
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 504
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 505 /* recursive call to add all subdomains */
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 506 ret = scpsys_add_subdomain(scpsys, child);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 507 if (ret)
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 508 goto err_put_node;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 509 }
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 510
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 511 return 0;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 512
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 513 err_put_node:
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 514 of_node_put(child);
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 515 return ret;
59b644b01cf48d Enric Balletbo i Serra 2020-10-30 516 }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip