Re: [PATCH v2] pinctrl: ingenic: add missing call to of_node_put()

From: Linus Walleij
Date: Wed Mar 03 2021 - 09:40:49 EST


On Fri, Feb 26, 2021 at 2:35 AM Yang Li <yang.lee@xxxxxxxxxxxxxxxxx> wrote:

> In one of the error paths of the for_each_child_of_node() loop in
> ingenic_gpio_probe, add missing call to of_node_put().
>
> Fix the following coccicheck warning:
> ./drivers/pinctrl/pinctrl-ingenic.c:2485:1-23: WARNING: Function
> "for_each_child_of_node" should have of_node_put() before return around
> line 2489.
>
> Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx>
> Signed-off-by: Yang Li <yang.lee@xxxxxxxxxxxxxxxxx>

Oops applied this rather than v1.

Yours,
Linus Walleij