Re: [PATCH v2 04/10] fsdax: Introduce dax_iomap_cow_copy()

From: Christoph Hellwig
Date: Wed Mar 03 2021 - 10:38:47 EST


On Fri, Feb 26, 2021 at 08:20:24AM +0800, Shiyang Ruan wrote:
> + if (!copy_edge) {
> + ret = copy_mc_to_kernel(daddr, saddr, length);
> + return ret;

No need for the ret variable here, this can be:

if (!copy_edge)
return copy_mc_to_kernel(daddr, saddr, length);

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>